fix: adjust window position for monitor DPI

[JonasWischeropp]

1. Logical needs to be converted into Physical
2. anchor_<x|y> (line 246) is already a PhysicalPosition

Example:

Monitor: 1600px 900px with 150%

  "defaultPlacements": [
    {
      "anchor": "bottom_left",
      "offsetX": "0px",
      "offsetY": "-24px",
      "width": "100%",
      "height": "24px",
      "monitorSelection": {
        "type": "all"
      }
    }
  ]

Before the y-position was calculated by (1600+-24)*(2/3) and not by 1600+(-24*(3/2)).

I think that #115 might be related to this.

[lars-berger]

Ay thanks for the PR on this 🙏

It's so close to everything positioning nicely... but I was still able to reproduce a scaling issue with the default starter configs on one of the monitors like so:

[lars-berger]

Seems to work correctly if size/position is set twice:

#[cfg(target_os = "windows")]
{
  let _ = window.set_size(size);
  let _ = window.set_position(position);
  let _ = window.set_size(size);
  let _ = window.set_position(position); // < not sure whether this call is necessary or if it's only size that needs to be set twice
}

We do something similar in GlazeWM where we call SetWindowPos twice when doing cross-monitor moves with different DPI's.

Are you able to reproduce #116 btw? Wonder if this also fixes that issue

[JonasWischeropp]

After some testing, I was able to reproduce #116.
The bar was rendered outside of the monitor.

With the adjustments of this PR, the problem no longer occurred (with and without calling window.set_size and window.set_position twice).

[JonasWischeropp]

I was unable to reproduce any problems that require to set size and position twice.

[JonasWischeropp]

Never mind, I was able to reproduce the same problem you mentioned.
And with set_size and set_position twice it was fixed. Good catch, I would never have thought of that.

[lars-berger]

After some testing, I was able to reproduce #116. The bar was rendered outside of the monitor.

With the adjustments of this PR, the problem no longer occurred (with and without calling window.set_size and window.set_position twice).

Ay that's great 🙌

BTW, I think we should be scaling only pixel values and leaving % values (e.g. "width": "98%") untouched. Does that sound right? Otherwise, e.g. 98% ends up scaling to the full size of the monitor

[JonasWischeropp]

BTW, I think we should be scaling only pixel values and leaving % values (e.g. "width": "98%") untouched. Does that sound right? Otherwise, e.g. 98% ends up scaling to the full size of the monitor

Makes sense, I hadn't thought of that. I will make the change.

[JonasWischeropp]

Percentage values are no longer scaled.

[github-actions]

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀