github: Report code coverage #5
Conversation
ernestask
force-pushed
the
wip/ernestask/coverage
branch
2 times, most recently
from
f3b3c7d to
ccb1fb4
Compare
|
Right, using proc-macro2 is the issue: mozilla/grcov#494 |
|
That's too bad about the procedural macro incompatibility. I'd be happy to take your first 3 commits though. |
|
No rush to get the changes in. :D I’ll spend some more time later to figure things out. |
Since the filter allows all branches, it can be removed.
Currently, tests are run on 18.04 and 20.04, but 22.04 is out already, so this commit drops 18.04 and adds the latest release.
ernestask
force-pushed
the
wip/ernestask/coverage
branch
7 times, most recently
from
ca891e4 to
ef68725
Compare
ernestask
force-pushed
the
wip/ernestask/coverage
branch
from
ef68725 to
04659f6
Compare
|
And now we got somewhere. Now the problem is with uploading coverage results (a token is required for private repos). |
|
Thank you so much!! 😊 I'll try to make the repo public this weekend. I don't think it's ready for a cargo publish, but no reason to hide it either. |
|
Thanks for separating the commits in this PR by the way. The descriptions for each change made this easy to follow. |
| args: --all-features --no-fail-fast | ||
| env: | ||
| LLVM_PROFILE_FILE: "nldl-%p-%m.profraw" | ||
| RUSTFLAGS: '-Cinstrument-coverage' |
There was a problem hiding this comment.
Oh this flag is stable now? That's awesome.
|
@ernestask In case you were curious, we had to add the Ubuntu version to the Thanks again for your work here. Was fairly surprised by this and thought I'd pass knowledge. |
|
Oh, thanks! It made no sense when I was looking at it. |
Closes #4