Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1102: Refactoring around docker files #39

Merged
merged 6 commits into from
Jun 27, 2024
Merged

CSUB-1102: Refactoring around docker files #39

merged 6 commits into from
Jun 27, 2024

Commits on Jun 25, 2024

  1. Remove a binary artifact which should not be in git

    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    dedf4c6 View commit details
    Browse the repository at this point in the history

  2. Enable release pipeline on pull requests but don't push images 

    only push the resulting docker images if the CI job was not triggered on
a pull request (e.g. push to a release branch or manually triggered)
    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1b636ee View commit details
    Browse the repository at this point in the history

  3. Merge the 3 build jobs into one

    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cd2d4b9 View commit details
    Browse the repository at this point in the history

  4. Use build arguments and a single Dockerfile 

    remove the duplicate files and use a build argument for the different
images
    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    77f12df View commit details
    Browse the repository at this point in the history

  5. Don't use legacy ENV format 

    otherwise we get a warning:
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy
"ENV key value" format (line 33) Dockerfile:30
    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6d206c6 View commit details
    Browse the repository at this point in the history

  6. Don't hard-code uid for crunch user 

    b/c it leads to errors:
useradd: UID 1000 is not unique
    @atodorov
    atodorov committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    62a774f View commit details
    Browse the repository at this point in the history