Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update substrate to pick up peering fix #249

Closed
wants to merge 1 commit into from

Conversation

nathanwhit
Copy link
Contributor

@nathanwhit nathanwhit commented May 25, 2022

Description of proposed changes:
Updates substrate to include the changes from paritytech/substrate#11429 in order to improve the peering situation on testnet. (The update is from gluwa/substrate@57cab2f to gluwa/substrate@973dd74)

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

Codecov Report

Merging #249 (850c8fd) into testnet (5569ce8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           testnet     #249   +/-   ##
========================================
  Coverage    56.73%   56.73%           
========================================
  Files           33       33           
  Lines         5485     5485           
========================================
  Hits          3112     3112           
  Misses        2373     2373           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@atodorov
Copy link
Contributor

@nathanwhit don't we need the same patch/PR opened against dev as well ? I think we do.

@nathanwhit nathanwhit closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants