Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make complains about 'client_uid' never being NULL #4245

Open
Shwetha-Acharya opened this issue Oct 20, 2023 · 0 comments
Open

make complains about 'client_uid' never being NULL #4245

Shwetha-Acharya opened this issue Oct 20, 2023 · 0 comments
Assignees
@sanjurakonde

Comments

@Shwetha-Acharya
Copy link
Contributor

13:46:46 client_t.c: In function 'gf_client_dump_fdtables':
13:46:46 client_t.c:601:17: error: the comparison will always evaluate as 'true' for the address of 'client_uid' will never be NULL [-Werror=address]
13:46:46 601 | if (client->client_uid) {
13:46:46 | ^~~~~~
13:46:46 In file included from ./glusterfs/stack.h:31,
13:46:46 from ./glusterfs/xlator.h:53,
13:46:46 from ./glusterfs/fd.h:79,
13:46:46 from ./glusterfs/inode.h:33,
13:46:46 from glusterfs/statedump.h:15,
13:46:46 from client_t.c:12:
13:46:46 ./glusterfs/client_t.h:59:10: note: 'client_uid' declared here
13:46:46 59 | char client_uid[];
13:46:46 | ^~~~~~~~~~

Refer: https://build.gluster.org/job/gh_32-bit-build-smoke/4059/console
Shwetha-Acharya pushed a commit to Shwetha-Acharya/glusterfs that referenced this issue Oct 20, 2023
@Shwetha-Acharya
checksum.c: Use the EVP API to compute the MD5 checksum
5e88e7c 
As MD5 function has been marked as deprecated in OpenSSL 3.0, this change
uses EVP (Envelope) API to compute the MD5 checksum.
Reference:
https://www.openssl.org/docs/man1.0.2/man3/EVP_md5.html

Also resolved make error of 'client_uid' never being NULL.

Fixes: gluster#4243 and gluster#4245
Signed-off-by: root <root@li-9b8608cc-32eb-11b2-a85c-953d7297bf45.ibm.com>
Shwetha-Acharya pushed a commit to Shwetha-Acharya/glusterfs that referenced this issue Oct 20, 2023
@Shwetha-Acharya
checksum.c: Use the EVP API to compute the MD5 checksum
4f075e4 
As MD5 function has been marked as deprecated in OpenSSL 3.0, this change
uses EVP (Envelope) API to compute the MD5 checksum.
Reference:
https://www.openssl.org/docs/man1.0.2/man3/EVP_md5.html

Also resolved make error of 'client_uid' never being NULL.

Fixes: gluster#4243 and gluster#4245
Signed-off-by: root <Shwetha.K.Acharya@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjurakonde sanjurakonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shwetha-Acharya @sanjurakonde