Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related AWT libraries and use correct order when linking #905

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add related AWT libraries and use correct order when linking #905

merged 1 commit into from
Apr 19, 2021

Conversation

jperedadnr
Copy link
Contributor

@jperedadnr jperedadnr commented Apr 16, 2021 •
edited
Loading

Issue

Fixes #878

Progress

johanvos
johanvos reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the size of HelloFX before and after this PR? (the size of the image)

@alaa-az
Copy link
Contributor

alaa-az commented Apr 19, 2021

Please link awt_xawt instead of awt_headless coz as this is a JavaFX app so it should be heady.

@jperedadnr
Copy link
Contributor Author

HelloFX, with or without AWT libs: 67.2 MB

@johanvos
Copy link
Contributor

awt_xawt will pull in many additional build and runtime dependencies, so I think that should be done (conditionally) in a follow-up issue.

@jperedadnr jperedadnr merged commit 64fe3ea into gluonhq:master Apr 19, 2021
@jperedadnr jperedadnr deleted the 878-awt branch April 19, 2021 11:31
@jperedadnr jperedadnr mentioned this pull request Apr 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanvos johanvos johanvos approved these changes

@tiainen tiainen Awaiting requested review from tiainen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWT libraries are not included
3 participants
@jperedadnr @alaa-az @johanvos