Fix: Do not update VM Computer asset if denied by rules #18940
+11
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Hello,
Since #18932 hasn't been approved, there's no reliable way to avoid ESX inventory override the inventory of VMs made with GLPI-Agent installed locally. I use ESX inventory because some machines do not allow the GLPI-Agent be installed locally. The only way to filter those machines is using the "Model" field, since ESX inventory do not provide them, but GLPI-Agent does, so I created the following filter rules:
It denies the importing of assets with no "Model" field is already present but is missing on inventory data, but that wasn't working as expected and the local GLPI-Agent data was being overriden by ESX inventory anyway. It happens because GLPI only validates the rules when adding a VM (as can be seen on the same file edited on this commit), but not for update. Now it also checks the rules when updating the Computer asset, and only updates it if rules allows it, thus avoiding the override.
Screenshots (if appropriate):