Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra break on Management Port (Network Ports - Asset) #18920

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

eduardomozart
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

This PR removes the extra break on Management port section:

image

After this PR:

image

src/NetworkPort.php Outdated Show resolved Hide resolved
@eduardomozart
Copy link
Contributor Author

Hello @cedric-anne, I've updated this PR as requested. De facto, it got way more easier to read now.

@cedric-anne cedric-anne added this to the 10.0.18 milestone Feb 5, 2025
@trasher trasher merged commit a272eb7 into glpi-project:10.0/bugfixes Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants