Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to NumFOCUS to README. #202

Merged
merged 6 commits into from
Jul 8, 2019
Merged

Add links to NumFOCUS to README. #202

merged 6 commits into from
Jul 8, 2019

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jun 28, 2019

Add badge and section to README.

@codecov
Copy link

codecov bot commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files          37       37           
  Lines        5582     5582           
=======================================
  Hits         3631     3631           
  Misses       1951     1951

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c489030...6da5714. Read the comment docs.

@csadorf csadorf requested review from a team and mikemhenry June 28, 2019 23:53
bdice
bdice reviewed Jul 2, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@csadorf csadorf removed request for mikemhenry and a team July 5, 2019 14:01
@b-butler b-butler added this to the v1.1.1 milestone Jul 5, 2019
@csadorf csadorf assigned csadorf and mikemhenry and unassigned csadorf Jul 5, 2019
@csadorf csadorf marked this pull request as ready for review July 6, 2019 19:01
@csadorf
Copy link
Contributor Author

csadorf commented Jul 6, 2019

I've adapted @bdice 's suggestion, otherwise I think this is ready for merge.

bdice
bdice approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments - I'd consider it ready to merge but it could be changed if you like my suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@csadorf csadorf requested a review from mikemhenry July 7, 2019 18:15
@csadorf
Copy link
Contributor Author

csadorf commented Jul 7, 2019

@mikemhenry This should be ready to merge.

mikemhenry
mikemhenry approved these changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csadorf csadorf merged commit 774333d into master Jul 8, 2019
@csadorf csadorf deleted the misc/numfocus branch July 8, 2019 16:42
@csadorf csadorf modified the milestones: v1.1.1, v1.2.0 Jul 17, 2019
@matthewfeickert matthewfeickert mentioned this pull request Apr 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemhenry mikemhenry mikemhenry approved these changes

@bdice bdice bdice approved these changes

Assignees

@mikemhenry mikemhenry

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@csadorf @bdice @mikemhenry @b-butler