Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.12. #205

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Test Python 3.12. #205

merged 7 commits into from
Nov 9, 2023

Conversation

joaander
Copy link
Member

@joaander joaander commented Nov 9, 2023

Description

Test on Python 3.12. Also limit the number of jobs that run on limited macOS and windows runners.

Motivation and Context

  • Ensure that dashboard works with Python 3.12.
  • Previously, the actions workflow ran the full matrix of tests on all 3 operating systems. This redundant testing adds significantly to the total time needed to test a push as GitHub Actions provides only a limited number of free macOS and Windows runners.

This PR limits macos and windows to 1 job each on the newest version of python and tests the full matrix on Linux.

Checklist:

Also limit the number of jobs that run on limited macOS and windows runners.
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #205 (96c69d9) into main (4f6a083) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   70.02%   70.02%           
=======================================
  Files          21       21           
  Lines         884      884           
  Branches      159      159           
=======================================
  Hits          619      619           
  Misses        220      220           
  Partials       45       45           

@joaander
Copy link
Member Author

joaander commented Nov 9, 2023

Correction: Windows runners are not limited (https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration). However, Windows runners are slower than the Linux runners, so Linux is preferred for the full matrix.

Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with this as-is but see note on testing oldest versions?

.github/workflows/run-pytest.yml Show resolved Hide resolved
@joaander joaander marked this pull request as ready for review November 9, 2023 15:24
@joaander joaander requested review from a team as code owners November 9, 2023 15:24
@joaander joaander requested review from kidrahahjo and Tobias-Dwyer and removed request for a team November 9, 2023 15:24
@cbkerr cbkerr enabled auto-merge (squash) November 9, 2023 16:00
@cbkerr cbkerr merged commit ac59c64 into main Nov 9, 2023
11 checks passed
@cbkerr cbkerr deleted the test-python-3.12 branch November 9, 2023 16:29
@cbkerr cbkerr added this to the v0.7.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants