Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇👌 Exclude dependabot push CI runs #978

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jan 29, 2022

Since dependabot opens its branches for PRs on our repo and we require a linear history builds on push and pull_request are the same. And by deactivating the CI for the push event on dependabot branches we save time and energy.

Change summary

  • 🚇👌 Exclude dependabot push CI runs

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner January 29, 2022 14:58
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/exclude-dependabot-push-ci

@s-weigand s-weigand force-pushed the exclude-dependabot-push-ci branch from 2311548 to 4b5e078 Compare January 29, 2022 15:03
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [96b42630]       [4b5e0784]
     <v0.5.1>                   
         55.4±1ms       53.7±0.5ms     0.97  BenchmarkOptimize.time_optimize(False, False, False)
        59.3±30ms        58.8±30ms     0.99  BenchmarkOptimize.time_optimize(False, False, True)
       54.7±0.7ms       52.5±0.5ms     0.96  BenchmarkOptimize.time_optimize(False, True, False)
        66.3±10ms       56.7±0.9ms    ~0.86  BenchmarkOptimize.time_optimize(False, True, True)
       66.3±0.3ms       64.7±0.5ms     0.98  BenchmarkOptimize.time_optimize(True, False, False)
        71.4±30ms         69.7±3ms     0.98  BenchmarkOptimize.time_optimize(True, False, True)
       65.9±0.5ms       64.4±0.2ms     0.98  BenchmarkOptimize.time_optimize(True, True, False)
       70.8±0.7ms         101±40ms    ~1.42  BenchmarkOptimize.time_optimize(True, True, True)
             209M             200M     0.96  IntegrationTwoDatasets.peakmem_optimize
       1.83±0.01s       1.78±0.06s     0.97  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [4370ad96]       [4b5e0784]
         54.4±1ms       53.7±0.5ms     0.99  BenchmarkOptimize.time_optimize(False, False, False)
        59.2±20ms        58.8±30ms     0.99  BenchmarkOptimize.time_optimize(False, False, True)
         54.2±2ms       52.5±0.5ms     0.97  BenchmarkOptimize.time_optimize(False, True, False)
         59.6±2ms       56.7±0.9ms     0.95  BenchmarkOptimize.time_optimize(False, True, True)
         65.8±2ms       64.7±0.5ms     0.98  BenchmarkOptimize.time_optimize(True, False, False)
         70.7±2ms         69.7±3ms     0.99  BenchmarkOptimize.time_optimize(True, False, True)
         66.1±2ms       64.4±0.2ms     0.97  BenchmarkOptimize.time_optimize(True, True, False)
        94.4±30ms         101±40ms     1.07  BenchmarkOptimize.time_optimize(True, True, True)
             201M             200M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.80±0.02s       1.78±0.06s     0.99  IntegrationTwoDatasets.time_optimize

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #978 (4b5e078) into main (4370ad9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #978   +/-   ##
=====================================
  Coverage   85.6%   85.6%           
=====================================
  Files         90      90           
  Lines       4883    4883           
  Branches     916     916           
=====================================
  Hits        4181    4181           
  Misses       552     552           
  Partials     150     150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4370ad9...4b5e078. Read the comment docs.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. No need to waste resources.

@s-weigand s-weigand merged commit 5a8711f into glotaran:main Jan 29, 2022
@s-weigand s-weigand deleted the exclude-dependabot-push-ci branch January 29, 2022 16:13
s-weigand added a commit to glotaran/pyglotaran-extras that referenced this pull request Jan 29, 2022
s-weigand added a commit to s-weigand/pyglotaran-extras that referenced this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants