Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Improve packaging tooling #923

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Dec 2, 2021

This fixes changelog.md missing from the tarball and adds an additional tool to check that all need files are included in the distribution.

Change summary

  • 🩹 Changed old HISTORY.rst to changelog.md in manifest
  • 🔧 Added 'check-manifest' pre-commit hook to check for missing files in the distribution

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's

@s-weigand s-weigand requested a review from a team as a code owner December 2, 2021 13:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/improve-packaging

@s-weigand s-weigand marked this pull request as draft December 2, 2021 13:03
@s-weigand
Copy link
Member Author

I made it a draft because I want #922 merged first, so I can add the change to the changelog 😉

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [96b42630]       [d6e64003]
     <v0.5.1>                   
       50.9±0.2ms       51.8±0.3ms     1.02  BenchmarkOptimize.time_optimize(False, False, False)
       54.8±0.6ms        60.0±10ms     1.10  BenchmarkOptimize.time_optimize(False, False, True)
       51.0±0.3ms       51.9±0.3ms     1.02  BenchmarkOptimize.time_optimize(False, True, False)
       55.4±0.5ms       55.6±0.4ms     1.00  BenchmarkOptimize.time_optimize(False, True, True)
       61.9±0.2ms       62.9±0.2ms     1.02  BenchmarkOptimize.time_optimize(True, False, False)
         65.7±5ms       66.6±0.6ms     1.01  BenchmarkOptimize.time_optimize(True, False, True)
       62.2±0.4ms       62.7±0.3ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
        65.6±30ms       66.9±0.5ms     1.02  BenchmarkOptimize.time_optimize(True, True, True)
             193M             195M     1.01  IntegrationTwoDatasets.peakmem_optimize
       1.72±0.06s       1.75±0.05s     1.02  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [48ed9cf3]       [d6e64003]
       51.2±0.6ms       51.8±0.3ms     1.01  BenchmarkOptimize.time_optimize(False, False, False)
       54.9±0.6ms        60.0±10ms     1.09  BenchmarkOptimize.time_optimize(False, False, True)
       51.1±0.1ms       51.9±0.3ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
         55.2±1ms       55.6±0.4ms     1.01  BenchmarkOptimize.time_optimize(False, True, True)
       62.6±0.3ms       62.9±0.2ms     1.01  BenchmarkOptimize.time_optimize(True, False, False)
       65.8±0.5ms       66.6±0.6ms     1.01  BenchmarkOptimize.time_optimize(True, False, True)
       62.3±0.4ms       62.7±0.3ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
        66.4±20ms       66.9±0.5ms     1.01  BenchmarkOptimize.time_optimize(True, True, True)
             197M             195M     0.99  IntegrationTwoDatasets.peakmem_optimize
       1.67±0.04s       1.75±0.05s     1.05  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #923 (d6e6400) into main (48ed9cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #923   +/-   ##
=====================================
  Coverage   85.1%   85.1%           
=====================================
  Files         85      85           
  Lines       4799    4799           
  Branches     921     921           
=====================================
  Hits        4085    4085           
  Misses       562     562           
  Partials     152     152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ed9cf...d6e6400. Read the comment docs.

@jsnel jsnel force-pushed the improve-packaging branch from b24be1d to f6d9df5 Compare January 1, 2022 02:10
@jsnel jsnel marked this pull request as ready for review January 1, 2022 09:56
@jsnel
Copy link
Member

jsnel commented Jan 2, 2022

I made it a draft because I want #922 merged first, so I can add the change to the changelog 😉

#922 is merged, so that can be done now ^^

jsnel added a commit to s-weigand/pyglotaran that referenced this pull request Jan 4, 2022
-  🔧 Improve packaging tooling (glotaran#923)
-  🔧 Improve packaging tooling (glotaran#923)
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements!

@jsnel jsnel merged commit b1f678a into glotaran:main Jan 5, 2022
@jsnel jsnel deleted the improve-packaging branch January 5, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants