Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fixed artifact download in pr_benchmark_reaction workflow #907

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 17, 2021

This change was needed due to updating to actions/github-script@v5 (#845, merged via #884 )

Change summary

  • 🩹 Fixed artifact download in pr_benchmark_reaction workflow

  • ✔️ Passing the tests (mandatory for all PR's)

This change was needed due to updating to actions/github-script@v5
@s-weigand s-weigand requested a review from a team as a code owner November 17, 2021 08:27
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-pr-bench-reaction

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #907 (d3b47e1) into main (b3b8b87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #907   +/-   ##
=====================================
  Coverage   84.8%   84.8%           
=====================================
  Files         81      81           
  Lines       4610    4610           
  Branches     851     851           
=====================================
  Hits        3910    3910           
  Misses       558     558           
  Partials     142     142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b8b87...d3b47e1. Read the comment docs.

@s-weigand
Copy link
Member Author

It doesn't work yet since the workflow which gets executed needs to live on the default branch.

@s-weigand
Copy link
Member Author

I switched the default branch on my fork to this branch and made a dummy PR.
The workflow now fails on commenting since this is hardcoded to glotaran/pyglotaran and the PR with that number doesn't exist here.
So it works as expected. 🎉

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@s-weigand s-weigand merged commit 9865243 into glotaran:main Nov 17, 2021
@s-weigand s-weigand deleted the fix-pr-bench-reaction branch November 17, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants