-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Improve ordering in k_matrix involved_compartments function #791
[Backport] Improve ordering in k_matrix involved_compartments function #791
Conversation
Avoiding the use of set to improve ordering Refactor at least guarantees better than random ordering using list(set(x)) Backport of a6a5a51 for improved consistency between v0.4.1 maintenance branch and staging-to-become-v0.5.0
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.23%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed! |
Benchmark is done. Checkout the benchmark result page. Benchmark diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## maintenance/v0.4.1 #791 +/- ##
==================================================
Coverage 81.8% 81.8%
==================================================
Files 79 79
Lines 3923 3924 +1
Branches 690 692 +2
==================================================
+ Hits 3211 3212 +1
Misses 593 593
Partials 119 119
Continue to review full report at Codecov.
|
Avoiding the use of set to improve ordering
Refactor at least guarantees better than random ordering using list(set(x))
Backport of a6a5a51 for improved consistency between v0.4.1 maintenance branch and staging-to-become-v0.5.0
Checklist