-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calls to clp_area_penalties where deprecated func is called #790
Update calls to clp_area_penalties where deprecated func is called #790
Conversation
The deprecated equal_area_penalties would be called in lieu of the new clp_area_penalties function The pyglotaran-examples have in their model still equal_area_penalties which is correctly swapped with clp_area_penalties but them model.equal_area_penalties was still called in some places instead of model.clp_area_penalties
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## staging #790 +/- ##
=======================================
Coverage 83.9% 83.9%
=======================================
Files 75 75
Lines 4185 4185
Branches 752 752
=======================================
Hits 3512 3512
Misses 538 538
Partials 135 135
Continue to review full report at Codecov.
|
Benchmark is done. Checkout the benchmark result page. Benchmark diffParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Ignore the codecov result comment which fails because the commit change single line function which are not under coverage so the relative change is through the roof even though the code coverage in absolute sense doesn't change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typical joern copy paste bugs, thx for fixing
…790) The deprecated equal_area_penalties would be called in lieu of the new clp_area_penalties function The pyglotaran-examples have in their model still equal_area_penalties which is correctly swapped with clp_area_penalties but them model.equal_area_penalties was still called in some places instead of model.clp_area_penalties
The deprecated equal_area_penalties would be called in lieu of the new clp_area_penalties function
The pyglotaran-examples have in their model still equal_area_penalties which is correctly swapped with clp_area_penalties but them model.equal_area_penalties was still called in some places instead of model.clp_area_penalties
Checklist
Closes issues
closes #789