-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ordering in k_matrix involved_compartments function #788
Improve ordering in k_matrix involved_compartments function #788
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #788 +/- ##
=======================================
Coverage 83.9% 83.9%
=======================================
Files 75 75
Lines 4185 4186 +1
Branches 752 754 +2
=======================================
+ Hits 3512 3513 +1
Misses 538 538
Partials 135 135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work for now.
Will be revised in 0.6
Avoiding the use of set to improve ordering Refactor at least guarantees better than random ordering using list(set(x)) TODO: further improve ordering to use initial_concentrations ordering
6a1f725
to
2a76a0b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Benchmark is done. Checkout the benchmark result page. Benchmark diffParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Avoiding the use of set to improve ordering Refactor at least guarantees better than random ordering using list(set(x)) TODO: further improve ordering to use initial_concentrations ordering
Avoiding the use of set to improve ordering
Refactor at least guarantees better than random ordering using list(set(x))
TODO: further improve ordering to use initial_concentrations ordering
Checklist
Closes issues
closes #787