Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Move API documentation from User to Developer Docs #776

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Aug 13, 2021

Since the API documentation is mainly aimed at developer is make more sense to have it in there than in the user docs.

Change summary

  • Moved API documentation to the developer documentation section

Checklist

  • ✔️ Passing the tests (mandatory!)

Closes issues

closes #601

@s-weigand s-weigand requested review from a team as code owners August 13, 2021 19:03
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/move-api-docs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@s-weigand s-weigand changed the title 📚 Moved API documentation from User to Developer Docs 📚 Move API documentation from User to Developer Docs Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #776 (5639dae) into main (5efcf0c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #776   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files         79      79           
  Lines       4024    4024           
  Branches     706     706           
=====================================
  Hits        3291    3291           
  Misses       606     606           
  Partials     127     127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efcf0c...5639dae. Read the comment docs.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [dc00e6da]       [5639dae1]
     <v0.4.0>                   
       49.1±0.5ms       48.4±0.4ms     0.99  BenchmarkOptimize.time_optimize(False, False, False)
        269±0.4ms          266±4ms     0.99  BenchmarkOptimize.time_optimize(False, False, True)
       71.0±0.3ms         71.0±1ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
       72.9±0.2ms         71.8±2ms     0.98  BenchmarkOptimize.time_optimize(False, True, True)
       49.2±0.7ms       57.1±0.6ms    ~1.16  BenchmarkOptimize.time_optimize(True, False, False)
        269±0.7ms          275±4ms     1.02  BenchmarkOptimize.time_optimize(True, False, True)
+      70.9±0.3ms         83.5±1ms     1.18  BenchmarkOptimize.time_optimize(True, True, False)
+      73.4±0.5ms       84.8±0.6ms     1.16  BenchmarkOptimize.time_optimize(True, True, True)
             183M             183M     1.00  IntegrationTwoDatasets.peakmem_create_result
             204M             199M     0.98  IntegrationTwoDatasets.peakmem_optimize
          227±2ms          234±2ms     1.03  IntegrationTwoDatasets.time_create_result
       4.71±0.01s       5.70±0.05s    ~1.21  IntegrationTwoDatasets.time_optimize

@jsnel jsnel merged commit 482a53b into glotaran:main Aug 13, 2021
@jsnel jsnel deleted the move-api-docs branch August 13, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move 'API Documentation' from 'USER DOCUMENTATION' to 'DEVELOPER DOCUMENTATION'
2 participants