-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix for baseline megacomplex #762
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #762 +/- ##
=======================================
Coverage 80.4% 80.4%
=======================================
Files 70 70
Lines 4043 4043
Branches 720 720
=======================================
Hits 3252 3252
Misses 664 664
Partials 127 127
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for more information, see https://pre-commit.ci
Kudos, SonarCloud Quality Gate passed!
|
Benchmark is done. Checkout the benchmark result page. Benchmark diffParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. We currently don't have models with baseline as part of examples so this change should not break anything.
* Small fix for baseline megacomplex * Save baseline as name 'baseline'
* Small fix for baseline megacomplex * Save baseline as name 'baseline'
* Small fix for baseline megacomplex * Save baseline as name 'baseline'
Really small fix