Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for baseline megacomplex #762

Merged
merged 3 commits into from
Aug 7, 2021

Conversation

joernweissenborn
Copy link
Member

Really small fix

@joernweissenborn joernweissenborn requested a review from jsnel as a code owner August 7, 2021 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

Binder 👈 Launch a binder notebook on branch joernweissenborn/pyglotaran/fixbaseline

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #762 (c608329) into staging (08a2c0f) will not change coverage.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           staging    #762   +/-   ##
=======================================
  Coverage     80.4%   80.4%           
=======================================
  Files           70      70           
  Lines         4043    4043           
  Branches       720     720           
=======================================
  Hits          3252    3252           
  Misses         664     664           
  Partials       127     127           
Impacted Files Coverage Δ
...tin/megacomplexes/baseline/baseline_megacomplex.py 83.3% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a2c0f...c608329. Read the comment docs.

@s-weigand s-weigand self-requested a review August 7, 2021 13:47
Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [dc00e6da]       [c6083296]
     <v0.4.0>                   
-      42.5±0.2ms       31.9±0.5ms     0.75  BenchmarkOptimize.time_optimize(False, False, False)
-       238±0.9ms       36.3±0.6ms     0.15  BenchmarkOptimize.time_optimize(False, False, True)
-      61.5±0.2ms       52.3±0.4ms     0.85  BenchmarkOptimize.time_optimize(False, True, False)
       63.4±0.3ms       57.4±0.6ms    ~0.90  BenchmarkOptimize.time_optimize(False, True, True)
       42.7±0.1ms       40.6±0.2ms     0.95  BenchmarkOptimize.time_optimize(True, False, False)
-       238±0.6ms       45.5±0.5ms     0.19  BenchmarkOptimize.time_optimize(True, False, True)
       62.0±0.4ms       63.0±0.3ms     1.02  BenchmarkOptimize.time_optimize(True, True, False)
       63.8±0.3ms       68.3±0.5ms     1.07  BenchmarkOptimize.time_optimize(True, True, True)
             183M             182M     1.00  IntegrationTwoDatasets.peakmem_create_result
             201M             198M     0.99  IntegrationTwoDatasets.peakmem_optimize
-         197±1ms          159±2ms     0.81  IntegrationTwoDatasets.time_create_result
-      4.06±0.01s       1.30±0.05s     0.32  IntegrationTwoDatasets.time_optimize

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. We currently don't have models with baseline as part of examples so this change should not break anything.

@s-weigand s-weigand merged commit f41949f into glotaran:staging Aug 7, 2021
jsnel pushed a commit that referenced this pull request Aug 14, 2021
* Small fix for baseline megacomplex

* Save baseline as name 'baseline'
jsnel pushed a commit to jsnel/pyglotaran that referenced this pull request Aug 14, 2021
* Small fix for baseline megacomplex

* Save baseline as name 'baseline'
jsnel pushed a commit that referenced this pull request Sep 16, 2021
* Small fix for baseline megacomplex

* Save baseline as name 'baseline'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants