Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Add flake.nix for creating dev shells with nix. #1253

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

joernweissenborn
Copy link
Member

@joernweissenborn joernweissenborn commented Feb 20, 2023

This enables user with nix installed to work on pyglotaran. The flake creates a shell with python 3.10 and virtualenv installed and installs all dependencies on first creation.

@joernweissenborn joernweissenborn requested a review from a team as a code owner February 20, 2023 20:59
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch joernweissenborn/pyglotaran/dev/add_nix

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [356b9345]
     <v0.6.0>                   
!      42.4±0.2ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
!      44.7±0.3ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
!      42.3±0.2ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
!      44.8±0.3ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
!      52.5±0.2ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
!        139±10ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
!      52.3±0.3ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
!       57.8±10ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             206M             208M     1.01  IntegrationTwoDatasets.peakmem_optimize
-      1.87±0.06s       1.03±0.05s     0.55  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [356b9345]       [80abd6aa]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             208M             208M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.03±0.05s         997±20ms     0.96  IntegrationTwoDatasets.time_optimize

Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the failing pre-commit check please add a short guide on how to set things up in CONTRIBUTING.rst (would also interest me 😅).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 88.3% // Head: 88.3% // No change to project coverage 👍

Coverage data is based on head (80abd6a) compared to base (356b934).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1253   +/-   ##
=====================================
  Coverage   88.3%   88.3%           
=====================================
  Files        104     104           
  Lines       5092    5092           
  Branches     847     847           
=====================================
  Hits        4499    4499           
  Misses       477     477           
  Partials     116     116           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enjoy working with NixOS!

Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@s-weigand s-weigand merged commit 6a984fb into glotaran:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants