-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Add flake.nix for creating dev shells with nix. #1253
Conversation
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.6.0 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the failing pre-commit check please add a short guide on how to set things up in CONTRIBUTING.rst
(would also interest me 😅).
372be08
to
80abd6a
Compare
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 88.3% // Head: 88.3% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
=====================================
Coverage 88.3% 88.3%
=====================================
Files 104 104
Lines 5092 5092
Branches 847 847
=====================================
Hits 4499 4499
Misses 477 477
Partials 116 116 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enjoy working with NixOS!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This enables user with
nix
installed to work on pyglotaran. The flake creates a shell with python 3.10 and virtualenv installed and installs all dependencies on first creation.