Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Raise minimum dependency version to releases that support py310 #1170

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 6, 2022

Since our required minimum python version is 3.10 we should also raise the minimum version of our dependencies to version that support python 3.10.

I looked up the dependency version on conda-forge and checked if they have a Build starting with 'py310'

$ mamba search <dependency name> | grep py310

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)

I looked up the dependency version on conda-forge and checked if they have a Build starting with 'py310'
mamba search <dependency name> | grep py310
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/raise-min-dep-version

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 87.5% // Head: 87.5% // No change to project coverage 👍

Coverage data is based on head (cea5369) compared to base (2516e09).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1170   +/-   ##
=====================================
  Coverage   87.5%   87.5%           
=====================================
  Files        103     103           
  Lines       4895    4895           
  Branches     806     806           
=====================================
  Hits        4288    4288           
  Misses       489     489           
  Partials     118     118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsnel jsnel merged commit 5c9b56b into glotaran:main Nov 6, 2022
@jsnel jsnel deleted the raise-min-dep-version branch November 6, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants