Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Add pinned version of odfpy to requirements_dev.txt #1164

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 5, 2022

While setting up a new local environment for pyglotaran I found that the runtime dependency odfpy had no pinned version in requirements_dev.txt.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner November 5, 2022 12:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/add-missing-runtime-dependency

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [db1e5760]
     <v0.6.0>                   
!        72.6±2ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
!        145±30ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
!        72.2±2ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
!        118±40ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
!        88.8±1ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
!         102±9ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
!        88.1±4ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
!        123±40ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             206M             210M     1.02  IntegrationTwoDatasets.peakmem_optimize
-      2.41±0.05s       1.81±0.04s     0.75  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [db1e5760]       [e3f06098]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             210M             211M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.81±0.04s       1.78±0.02s     0.98  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 87.6% // Head: 87.6% // No change to project coverage 👍

Coverage data is based on head (f94346c) compared to base (e2b21c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1164   +/-   ##
=====================================
  Coverage   87.6%   87.6%           
=====================================
  Files        103     103           
  Lines       4899    4899           
  Branches     807     807           
=====================================
  Hits        4292    4292           
  Misses       489     489           
  Partials     118     118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand s-weigand force-pushed the add-missing-runtime-dependency branch from e3f0609 to f94346c Compare November 5, 2022 18:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@s-weigand s-weigand merged commit d6c2d23 into glotaran:main Nov 5, 2022
@s-weigand s-weigand deleted the add-missing-runtime-dependency branch November 5, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants