Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🩹🔧 Fix manifest check #1099

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 17, 2022

Recently the manifest-check CI test started to fail, while I don't completely understand what is going on there it seems to be some kind of version mismatch between setuptools and distutils (python builtin) in the CI python env.
Raising the requirement for setuptool to be at least the current version fixes this issue (might also work with a lower version, but 56.0.0 was the one installed in the broken env).

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner June 17, 2022 15:49
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-manifest-check

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1099 (ebbdbb7) into main (c047331) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1099   +/-   ##
=====================================
  Coverage   87.1%   87.1%           
=====================================
  Files        101     101           
  Lines       5339    5339           
  Branches     995     995           
=====================================
  Hits        4654    4654           
  Misses       530     530           
  Partials     155     155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c047331...ebbdbb7. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [c047331d]
     <v0.6.0>                   
         79.7±2ms         79.3±1ms     0.99  BenchmarkOptimize.time_optimize(False, False, False)
         116±40ms          170±8ms    ~1.47  BenchmarkOptimize.time_optimize(False, False, True)
         78.6±2ms         78.6±1ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
         169±50ms         156±20ms     0.93  BenchmarkOptimize.time_optimize(False, True, True)
         96.5±1ms         98.0±3ms     1.02  BenchmarkOptimize.time_optimize(True, False, False)
         106±30ms          102±4ms     0.96  BenchmarkOptimize.time_optimize(True, False, True)
         96.3±1ms       97.3±0.9ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
         139±30ms         106±50ms    ~0.77  BenchmarkOptimize.time_optimize(True, True, True)
             205M             206M     1.00  IntegrationTwoDatasets.peakmem_optimize
       2.38±0.07s       2.42±0.02s     1.02  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [c047331d]       [ebbdbb7f]
         79.3±1ms         80.0±1ms     1.01  BenchmarkOptimize.time_optimize(False, False, False)
          170±8ms         168±20ms     0.99  BenchmarkOptimize.time_optimize(False, False, True)
         78.6±1ms         79.0±3ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
         156±20ms         168±10ms     1.07  BenchmarkOptimize.time_optimize(False, True, True)
         98.0±3ms         95.7±2ms     0.98  BenchmarkOptimize.time_optimize(True, False, False)
          102±4ms          105±2ms     1.04  BenchmarkOptimize.time_optimize(True, False, True)
       97.3±0.9ms         99.8±1ms     1.03  BenchmarkOptimize.time_optimize(True, True, False)
         106±50ms          103±2ms     0.97  BenchmarkOptimize.time_optimize(True, True, True)
             206M             206M     1.00  IntegrationTwoDatasets.peakmem_optimize
       2.42±0.02s       2.38±0.07s     0.98  IntegrationTwoDatasets.time_optimize

@jsnel jsnel merged commit ff66d8a into glotaran:main Jun 17, 2022
@jsnel jsnel deleted the fix-manifest-check branch June 17, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants