-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇🩹🔧 Fix manifest check #1099
🚇🩹🔧 Fix manifest check #1099
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=====================================
Coverage 87.1% 87.1%
=====================================
Files 101 101
Lines 5339 5339
Branches 995 995
=====================================
Hits 4654 4654
Misses 530 530
Partials 155 155 Continue to review full report at Codecov.
|
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.6.0 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Recently the manifest-check CI test started to fail, while I don't completely understand what is going on there it seems to be some kind of version mismatch between setuptools and distutils (python builtin) in the CI python env.
Raising the requirement for setuptool to be at least the current version fixes this issue (might also work with a lower version, but
56.0.0
was the one installed in the broken env).Change summary
Checklist