Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Set sourcery-ai target python version to 3.8 #1095

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 11, 2022

We do not want sourcery to introduce code that isn't compatible with python 3.8, like the merge syntax added in python 3.9
, as it tried to do here.
The default python version of sourcery is python 3.9

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner June 11, 2022 13:37
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/sourcery-config

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1095 (60115bd) into main (60115bd) will not change coverage.
The diff coverage is n/a.

❗ Current head 60115bd differs from pull request most recent head a4c7c3f. Consider uploading reports for the commit a4c7c3f to get more accurate results

@@          Coverage Diff          @@
##            main   #1095   +/-   ##
=====================================
  Coverage   87.1%   87.1%           
=====================================
  Files        101     101           
  Lines       5339    5339           
  Branches     995     995           
=====================================
  Hits        4654    4654           
  Misses       530     530           
  Partials     155     155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60115bd...a4c7c3f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [60115bde]
     <v0.6.0>                   
       53.0±0.3ms         54.5±2ms     1.03  BenchmarkOptimize.time_optimize(False, False, False)
       56.2±0.3ms       56.2±0.5ms     1.00  BenchmarkOptimize.time_optimize(False, False, True)
       53.1±0.3ms       52.8±0.4ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
       56.7±0.5ms         55.9±1ms     0.99  BenchmarkOptimize.time_optimize(False, True, True)
       63.7±0.6ms       63.6±0.9ms     1.00  BenchmarkOptimize.time_optimize(True, False, False)
        73.6±30ms         67.5±5ms     0.92  BenchmarkOptimize.time_optimize(True, False, True)
       64.0±0.6ms       63.1±0.4ms     0.99  BenchmarkOptimize.time_optimize(True, True, False)
        67.0±40ms         66.3±5ms     0.99  BenchmarkOptimize.time_optimize(True, True, True)
             204M             205M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.70±0.04s       1.72±0.06s     1.02  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [60115bde]       [a4c7c3fd]
         54.5±2ms       52.8±0.5ms     0.97  BenchmarkOptimize.time_optimize(False, False, False)
       56.2±0.5ms         56.3±1ms     1.00  BenchmarkOptimize.time_optimize(False, False, True)
       52.8±0.4ms       52.8±0.4ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
         55.9±1ms       55.9±0.5ms     1.00  BenchmarkOptimize.time_optimize(False, True, True)
       63.6±0.9ms       63.2±0.4ms     0.99  BenchmarkOptimize.time_optimize(True, False, False)
         67.5±5ms        84.5±30ms    ~1.25  BenchmarkOptimize.time_optimize(True, False, True)
       63.1±0.4ms       63.0±0.4ms     1.00  BenchmarkOptimize.time_optimize(True, True, False)
         66.3±5ms         67.0±3ms     1.01  BenchmarkOptimize.time_optimize(True, True, True)
             205M             204M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.72±0.06s       1.70±0.05s     0.98  IntegrationTwoDatasets.time_optimize

jsnel
jsnel previously approved these changes Jun 11, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@jsnel jsnel merged commit 661f2d4 into glotaran:main Jun 12, 2022
@s-weigand s-weigand deleted the sourcery-config branch June 12, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants