♻️ Refactor DatasetModel to use properties

[s-weigand]

Version information

• pyglotaran version: main (2f1afe7)
• Python version: all
• Operating System: all

Describe the refactoring

Currently DatasetModel uses a lot of get_ and set_ methods

pyglotaran/glotaran/model/dataset_model.py

Lines 157 to 163 in 2f1afe7

	def set_coordinates(self, coords: dict[str, np.ndarray]):
	"""Sets the dataset model's coordinates."""
	self._coords = coords
	def get_coordinates(self) -> dict[Hashable, np.ndarray]:
	"""Gets the dataset model's coordinates."""
	return self._coords

The same functionality could be achieved using properties and setter.

Using get_ and set_ is c++ like from the 90's, we have nice syntax sugar let's use it.

In [4]: import this
The Zen of Python, by Tim Peters

Beautiful is better than ugly.
...

Additional context

Besides refactoring of glotaran/model/dataset_model.py this will need additional changes to the tests and where it is used.

[fidelak]

Would you mind if I worked on this one?

[s-weigand]

@fidelak Sorry, I just talked to @joernweissenborn and this issue is quite tricky since it requires to interact with our runtime "decorator magic" (code that writes code).
But #807 should be a good first issue.

[fidelak]

@s-weigand I assume you're talking about the follow up in #815? I will give it a shot

[s-weigand]

Oops, yes I meant #815 ofc 😅
@fidelak Thanks for contributing 😄

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to lack of recent activity. Please open a new issue if you're still encountering this problem. Thanks for your contributions!