Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor tests to be more readable (follow-up to #807) #815

Closed
s-weigand opened this issue Sep 13, 2021 · 4 comments
Closed

♻️ Refactor tests to be more readable (follow-up to #807) #815

s-weigand opened this issue Sep 13, 2021 · 4 comments
Labels
Status: Lack of interest Issue went stale | cold | lack of (user) interest Type: Enhancement Feature requests
Milestone

Comments

@s-weigand
Copy link
Member

s-weigand commented Sep 13, 2021

Is your feature request related to a problem? Please describe.

Currently, most of the tests use Model.from_dict with 20+ lines dicts to define the model and this makes it harder to spot the differences between tests and to detect problems in tests.
#807 implements a simple draft of how tests could be refactored and made more readable.

Describe the solution you'd like

While tests should be verbose, they should also be readable and understandable.
Thus an autogenerated model dict generated by only the needed parameters as proposed in #807 would help to simplify tests and make it a lot easier to spot the differences between tests and detect errors.

Since this would be a test refactor it should only change:

  1. Tests which use Model.from_dict
  2. The model dict generators in glotaran.testing

Additional context

The tests that could quickly be changed are listed in #807 (comment)

@s-weigand
Copy link
Member Author

Taken by @fidelak

@s-weigand s-weigand removed the Status: Available Can be picked up to work on label Sep 18, 2021
@jsnel jsnel removed the good first issue Good for newcomers label Oct 2, 2021
@jsnel
Copy link
Member

jsnel commented Oct 2, 2021

After some further consideration we realize that we currently don't have "good first issues" that don't require some amount of domain knowledge, so I removed that label. See also: #837

If you did manage to do something already @fidelak please let us know, but if you didn't start yet then no worries, we'll pick this up internally.

@s-weigand s-weigand modified the milestones: v0.6.0, v0.7.0 May 17, 2022
@s-weigand s-weigand modified the milestones: v0.7.0, v0.8.0 Feb 4, 2023
@stale
Copy link

stale bot commented Jun 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Lack of interest Issue went stale | cold | lack of (user) interest label Jun 19, 2023
Copy link

stale bot commented Dec 19, 2023

This issue has been closed due to lack of recent activity. Please open a new issue if you're still encountering this problem. Thanks for your contributions!

@stale stale bot closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Lack of interest Issue went stale | cold | lack of (user) interest Type: Enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

2 participants