Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Fix typo in internal function name #94

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 19, 2022

Just fixed a typo (introduced by me) that bugged me 😅

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner June 19, 2022 12:39
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 19, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.87 ⭐ 1.87 ⭐ 0.00
Method Length 61.78 🙂 61.78 🙂 0.00
Working memory 10.92 😞 10.92 😞 0.00
Quality 70.33% 🙂 70.33% 🙂 0.00%
Other metrics Before After Change
Lines 311 311 0
Changed files Quality Before Quality After Quality Change
pyglotaran_extras/plotting/plot_svd.py 70.33% 🙂 70.33% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyglotaran_extras/plotting/plot_svd.py plot_svd 2 ⭐ 145 😞 16 ⛔ 52.46% 🙂 Try splitting into smaller methods. Extract out complex expressions
pyglotaran_extras/plotting/plot_svd.py plot_lsv_residual 3 ⭐ 59 ⭐ 13 😞 66.87% 🙂 Extract out complex expressions
pyglotaran_extras/plotting/plot_svd.py _plot_svd_vectors 3 ⭐ 89 🙂 10 😞 67.55% 🙂 Extract out complex expressions
pyglotaran_extras/plotting/plot_svd.py plot_lsv_data 1 ⭐ 51 ⭐ 13 😞 70.13% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/fix-typo-in-internal-function

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #94 (cb3c743) into main (f05554b) will not change coverage.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   40.18%   40.18%           
=======================================
  Files          23       23           
  Lines         662      662           
  Branches       96       96           
=======================================
  Hits          266      266           
  Misses        396      396           
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_svd.py 19.40% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05554b...cb3c743. Read the comment docs.

@s-weigand s-weigand merged commit b222ea0 into glotaran:main Jun 19, 2022
@s-weigand s-weigand deleted the fix-typo-in-internal-function branch June 19, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants