-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add plot function for guidance spectra #92
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 2.01%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 40.72% 40.18% -0.55%
==========================================
Files 22 23 +1
Lines 631 662 +31
Branches 91 96 +5
==========================================
+ Hits 257 266 +9
- Misses 374 396 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Codecov is complaining that lines not under unit test are increasing, but that makes sense in absence of tests. :)
Yeah at some point we need to figure out how to properly test plot functions .... 😅🙈 |
This PR adds a new plot function for guidance spectra and prevents
plot_overview
from raising an exception when provided with guidance spectra data, by checking the dimensionality of the time coordinate and usingplot_guidance
if only a single time point is present.Change summary
Checklist
I also tested that it works with the PE2022 teaching material