Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧🩹 Remove github section in sourcery config due to bug in sourcery-ai #72

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

s-weigand
Copy link
Member

Looks like sourcery AI won't refactor branches when the github section is in the config.

My guess is that sourcery_branch: sourcery/{base_branch} isn't handled gracefully, when not triggered by a webhook (KeyError ?).

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner April 3, 2022 21:03
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/improve-sourcery-config

@s-weigand s-weigand changed the title 🩹 Remove github section in sourcery config due to bug in sourcery-ai 🔧🩹 Remove github section in sourcery config due to bug in sourcery-ai Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #72 (362b225) into main (a724021) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   40.85%   40.85%           
=======================================
  Files          22       22           
  Lines         629      629           
  Branches       90       90           
=======================================
  Hits          257      257           
  Misses        372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a724021...362b225. Read the comment docs.

@s-weigand s-weigand merged commit a7a9902 into glotaran:main Apr 3, 2022
@s-weigand s-weigand deleted the improve-sourcery-config branch April 3, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants