-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 Improve SVD plotting #64
Conversation
Since singular vectors with a lower index correspond to a bigger singular value their contribution is more important and thus they should be plotted on top of singular vectors with a higher index.
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 41.42% 40.85% -0.57%
==========================================
Files 22 22
Lines 618 629 +11
Branches 87 90 +3
==========================================
+ Hits 256 257 +1
- Misses 362 372 +10
Continue to review full report at Codecov.
|
As a reference about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 😊
This PR fixes #50 and also adds arguments to specify the number of residual vectors to plot.
As an additional bonus
plot_lsv_data
andplot_rsv_data
are now agnostic towards the x dimensions name, since the x dimension selection works by usingnot sv_index_dim
.Before:
After:
Change number of SVD vectors
Deactivate legend:
Change summary
Checklist
Closes issues
closes #50