Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Made adding a cycler to and axis opt out by using None #58

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Feb 5, 2022

This change is needed in order to reuse plot functions in loops where the cycler is controlled from the outside.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner February 5, 2022 21:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/opt-out-cycler

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #58 (99da23d) into main (d770951) will increase coverage by 0.60%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   40.88%   41.49%   +0.60%     
==========================================
  Files          22       22              
  Lines         609      617       +8     
  Branches       86       87       +1     
==========================================
+ Hits          249      256       +7     
- Misses        360      361       +1     
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_doas.py 0.00% <0.00%> (ø)
pyglotaran_extras/plotting/plot_svd.py 21.42% <14.28%> (+1.42%) ⬆️
pyglotaran_extras/plotting/plot_spectra.py 23.80% <33.33%> (+1.85%) ⬆️
pyglotaran_extras/plotting/plot_concentrations.py 46.15% <50.00%> (+4.48%) ⬆️
pyglotaran_extras/plotting/plot_overview.py 28.57% <50.00%> (+1.29%) ⬆️
pyglotaran_extras/plotting/plot_residual.py 31.57% <50.00%> (+3.80%) ⬆️
pyglotaran_extras/plotting/plot_traces.py 33.33% <50.00%> (+1.51%) ⬆️
pyglotaran_extras/plotting/utils.py 20.27% <100.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d770951...99da23d. Read the comment docs.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The one complaining bot about codecov can be ignored.

@jsnel jsnel merged commit 32b3882 into glotaran:main Feb 20, 2022
@s-weigand s-weigand deleted the opt-out-cycler branch February 20, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants