Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Update installation instruction for release on pipi #56

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Feb 5, 2022

Since the readme will be shown on PyPi we should also mention how to install it from there (@jsnel good catch thanks)

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner February 5, 2022 18:38
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/update-readme

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #56 (4ad49d9) into main (d5101e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   40.88%   40.88%           
=======================================
  Files          22       22           
  Lines         609      609           
  Branches       86       86           
=======================================
  Hits          249      249           
  Misses        360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5101e9...4ad49d9. Read the comment docs.

@s-weigand s-weigand changed the title 📚 Update installation instruction fro release on pipi 📚 Update installation instruction for release on pipi Feb 5, 2022
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@s-weigand s-weigand merged commit 85bef05 into glotaran:main Feb 5, 2022
@s-weigand s-weigand deleted the update-readme branch February 5, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants