Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix 'setup_case_study' when used with 'results_folder_root' #41

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

s-weigand
Copy link
Member

When using setup_case_study with results_folder_root, the output_folder_name is ignored.

This slipped because in the examples results_folder_root is always None (uses user home folder) and the test was wrong.

Change summary

  • 🩹 Also use output_folder_name when results_folder_root not None

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🧪 Adds new tests for the feature (mandatory for ✨ feature and 🩹 bug fix PR's)

@s-weigand s-weigand requested a review from a team as a code owner October 24, 2021 16:23
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/fix-setup-case-study

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #41 (0a5d86f) into main (90daa5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   40.70%   40.70%           
=======================================
  Files          22       22           
  Lines         597      597           
  Branches       77       77           
=======================================
  Hits          243      243           
  Misses        354      354           
Impacted Files Coverage Δ
tests/io/test_setup_case_study.py 0.00% <ø> (ø)
pyglotaran_extras/io/setup_case_study.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90daa5b...0a5d86f. Read the comment docs.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsnel jsnel merged commit fe6e00f into glotaran:main Oct 24, 2021
@s-weigand s-weigand deleted the fix-setup-case-study branch October 24, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants