✨ Add plot_fitted_traces function #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Also added some convenience functions for data pre proceessing
…rray 👌 result_dataset_mapping and thus also plot_data_and_fits and plot_fit_overview, no work with single file paths
…egths ♻️ This required to remove the argument 'wavelength_range' and instead pass the wavelengths directly to 'plot_fit_overview' which gives the user more control. For convenience the function 'select_plot_wavelengths' was added, which provies the functionality of 'wavelength_range'
'maximum_coordinate_range' and 'add_unique_figure_legend'
|
|
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
========================================
- Coverage 6.19% 4.26% -1.94%
========================================
Files 13 17 +4
Lines 355 516 +161
Branches 41 70 +29
========================================
Hits 22 22
- Misses 333 494 +161
Continue to review full report at Codecov.
|
This needs a feature added in pyglotaran 0.5.0, for older results it will show a warning.
jsnel
reviewed
Oct 22, 2021
jsnel
reviewed
Oct 22, 2021
jsnel
reviewed
Oct 22, 2021
jsnel
reviewed
Oct 22, 2021
jsnel
reviewed
Oct 22, 2021
jsnel
reviewed
Oct 22, 2021
jsnel
approved these changes
Oct 22, 2021
jsnel
requested changes
Oct 22, 2021
There was a problem hiding this comment.
Request to rename / move some functions/modules.
- Move
plot_data_and_fitsandplot_fit_overviewout ofdata.py(where see 4, 5, 6) - Rename
data.pytoplot_data.py(different PR) - Move
get_shifted_tracesout ofplot_traces.pytoutil.py, remove dummycalculate_x_ranges - Rename
plot_tracestoplot_concentrations(to indicate we mean something different than the data + fitted traces. - Move function in 1. to (now empty) plot_traces module.
- Rename
plot_fit_overviewtoplot_fitted_traces(which plots both data + fitted traces), which allows for a future plot function which can plot only data traces (so without fits) calledplot_data_traces. Omit the word overview which we reserve for the complete summary picture or mega pdf ^^.
|
I addressed the renaming and moving functions in 7ec2491 and ran the examples locally to verify that they still work. The PR should be ready for the final review now 🤞 |
s-weigand
changed the title
|
All tests are successful, the codecov/patch bots failing we are aware of - the coverage are currently provided by the examples of pyglotaran-examples running with this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new plotting overview function to show data and fitted traces, for multiple wavelengths across datasets.
The wavelengths need to be calculated/selected separately so the user has more control over what to plot, which is especially important for wavelength axes that aren't equidistant.
Example
The below plot was created from the simultaneous_analysis_6d_disp by adding the following lines of code
Change summary
After review
Checklist
Closes issues
closes #35