Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix use_svd_number not being passed on to plot_sv_data in plot_data_overview #221

Merged
merged 2 commits into from
Nov 12, 2023
Merged

🩹 Fix use_svd_number not being passed on to plot_sv_data in plot_data_overview #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861199a
🩹 Fix use_svd_number not being passed on to plot_sv_data in plot_data…
s-weigand Nov 12, 2023
eb90984
🚧📚 Added change to changelog
s-weigand Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
- 👌 Use weighted residual instead of residual plots if present (#216)
- 👌 Add color map arguments to plot_data_overview (#217)
- 👌 Add das_cycler and svd_cycler to plot collection functions (#218)
- 👌 Add use_svd_number switch to use SV number instead of index as label (#219)
- 🩹 Fix use_svd_number not being passed on to plot_sv_data in plot_data_overview (#221)

(changes-0_7_1)=

Expand Down
2 changes: 1 addition & 1 deletion pyglotaran_extras/plotting/plot_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def plot_data_overview(
cycler=svd_cycler,
use_svd_number=use_svd_number,
)
plot_sv_data(dataset, sv_ax)
plot_sv_data(dataset, sv_ax, use_svd_number=use_svd_number)
plot_rsv_data(
dataset,
rsv_ax,
Expand Down