Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Use weighted residual instead of residual plots if present #216

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 3, 2023

If the weighted residual is present in the result we should show it instead of the unweighted residual.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner November 3, 2023 15:00
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/weighted_residual-plots

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pyglotaran_extras/plotting/plot_residual.py 29.03% <0.00%> (ø)
pyglotaran_extras/plotting/plot_guidance.py 29.16% <0.00%> (-2.66%) ⬇️

📢 Thoughts on this report? Let us know!.

@jsnel jsnel merged commit efe1091 into glotaran:main Nov 3, 2023
28 checks passed
@s-weigand s-weigand deleted the weighted_residual-plots branch November 4, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants