-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add add_subplot_labels function #181
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 43.30% 44.90% +1.59%
==========================================
Files 27 27
Lines 979 1011 +32
Branches 142 149 +7
==========================================
+ Hits 424 454 +30
- Misses 548 549 +1
- Partials 7 8 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I do note that 'advanced' (or complex) functionality like this could do with some additional documentation in the form of examples (rather than just the API docstrings), something like some snippets in the readme, or example notebooks. Suggest we made an issue of this for a future PR. Because of the tight coupling between pyglotaran and the -extras it can be done in either repository, but it may make more sense to be in -extras as a self-contained example.
This adds
add_subplot_labels
as a convenience function to add subplot labels.Instead of duplicating code for each axis possibly creating inconsistency.
This function allows adding labels consistently for all axes
Change summary
Checklist