🩹 Fix crashes of plot_doas and plot_coherent_artifact for non dispersive IRF #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 44.32% 44.08% -0.24%
==========================================
Files 27 27
Lines 934 939 +5
Branches 135 137 +2
==========================================
Hits 414 414
- Misses 513 518 +5
Partials 7 7
☔ View full report in Codecov by Sentry. |
s-weigand
force-pushed
the
fix-doas-ca-plots-missing-spectral
branch
from
8c6d7c6 to
4acac73
Compare
jsnel
approved these changes
May 27, 2023
s-weigand
added a commit
to s-weigand/pyglotaran-extras
that referenced
this pull request
Jul 2, 2023
1 task
s-weigand
added a commit
to s-weigand/pyglotaran-extras
that referenced
this pull request
Jul 2, 2023
s-weigand
added a commit
that referenced
this pull request
Jul 2, 2023
This fixes crashes `plot_coherent_artifact` where an IRF without dispersion is used which omits the spectral dimension in the result data. ### Change summary - [🩹](53bbfb2) [Follow up fix for](53bbfb2) #173 <!-- Documentation changes, only needed if bigger changes were made --> <!-- Links to the changed sections - [section1](link_to_docs_built_for_the_PR) - [section2](link_to_docs_built_for_the_PR) --> ### Checklist - [x] ✔️ Passing the tests (mandatory for all PR's)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crashes of
plot_doasandplot_coherent_artifactwhere an IRF without dispersion is used which omits the spectral dimension in the result data.Change summary
Checklist