-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 Make plot_data_overview able to plot single trace data #137
👌 Make plot_data_overview able to plot single trace data #137
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.41%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov ReportBase: 44.94% // Head: 44.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 44.94% 44.79% -0.15%
==========================================
Files 29 29
Lines 930 942 +12
Branches 131 134 +3
==========================================
+ Hits 418 422 +4
- Misses 505 513 +8
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1724884
to
605244f
Compare
605244f
to
0e74501
Compare
0e74501
to
816850f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It's important to note that this is not suggesting to use plot_data_overview for plotting single traces, but more that when you end up calling this function in a larger context it doesn't crash when the dataset happens to a single trace.
This change allows
plot_data_overview
to be able to plot single trace data without crashing on a single axis dataset.The SVD part of the plot will be skipped since it does not make sense.
Pseudo code to try it our:
Change summary
Checklist