Introduce GCS ConnectorTable as mapping-like
#955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
sirosen
force-pushed
the
gcs-connector-map
branch
from
4fa7b7c to
bf9517b
Compare
ada-globus
previously requested changes
Jun 14, 2024
The `ConnectorTable` supports the following:
- class attribute access: `ConnectorTable.POSIX`
- classmethod lookup by name: `ConnectorTable.lookup("posix")
- classmethod lookup by ID: `ConnectorTable.lookup_by_id("...")`
- classmethod iteration: `ConnectorTable.all_connectors()`
The name-based lookups are normalized per some basic rules to make
most intelligible strings match.
Autodoc is extended to cover the new `ConnectorTable` as well as the
dataclass, `GlobusConnectServerConnector`, which it uses to represent
connector information.
Co-authored-by: Ada <107940310+ada-globus@users.noreply.github.com>
sirosen
force-pushed
the
gcs-connector-map
branch
from
04c9bc5 to
9eb9b9f
Compare
kurtmckee
reviewed
Jun 20, 2024
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
- The content is defined in a large tuple - The assignment of the tuple contents to the annotated classvar attributes is done in a post-class-definition loop - Tests refer to this tuple (`_connectors`) - A new test confirms that the tuple is trued-up to any/all `GlobusConnectServerConnector` attribute annotations
kurtmckee
reviewed
Jun 20, 2024
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
Rather than supporting lookups by name or ID via different methods, unify them into a single method per review. Co-authored-by: Kurt McKee <39996+kurtmckee@users.noreply.github.com>
kurtmckee
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConnectorTablesupports the following:ConnectorTable.POSIXConnectorTable.lookup("posix")ConnectorTable.lookup_by_id("...")ConnectorTable.all_connectors()The name-based lookups are normalized per some basic rules to make
most intelligible strings match.
Autodoc is extended to cover the new
ConnectorTableas well as thedataclass,
GlobusConnectServerConnector, which it uses to representconnector information.
📚 Documentation preview 📚: https://globus-sdk-python--955.org.readthedocs.build/en/955/