Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuthClient.create_policy signature #936

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Jan 5, 2024

I've taken another iteration on this approach to strip it all the way down to the bare essentials.
The new definition puts all of the compatibility code into the decorator. That means

  • the definition is now entirely correct in v3, and in v4 we can just remove the compat decorator
  • this approach to shimming lets us do a very simple zip rather than inspection of locals

This is done with a compatibility wrapper which unpacks arguments to ensure that legacy (positional-argument usage) is supported under SDK v3.


📚 Documentation preview 📚: https://globus-sdk-python--936.org.readthedocs.build/en/936/

This is done with a compatibility wrapper which unpacks arguments to
ensure that legacy (positional-argument usage) is supported under SDK
v3.
@sirosen sirosen force-pushed the fix-create-policy-3 branch from 087e863 to 79555ce Compare January 5, 2024 22:49
@sirosen sirosen merged commit ef5bc1d into globus:main Jan 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants