GCS get and update endpoint #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-globus
requested review from
aaschaer,
ada-globus,
kurtmckee and
sirosen
as code owners
sirosen
reviewed
Jan 2, 2024
sirosen
reviewed
Jan 5, 2024
|
I've offered an alternative (PR on this PR) here: derek-globus#1 I'd like us to discuss this more if we don't want to go down that path. |
- Get rid of `_MISSING_SENTINEL`, revert the old helpers to `None`-only, but don't use them for this class - Assign values directly, without worrying about applying converters in almost any cases - In the one case in which a converter is needed (`keywords`), apply it explicitly inline
sirosen
requested changes
Feb 2, 2024
sirosen
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sc-28586
What?
Added 2 new operations to the
GCSClientclass:gcs_client.get_endpoint()gcs_client.update_endpoint(EndpointDocument(...))Testing
📚 Documentation preview 📚: https://globus-sdk-python--933.org.readthedocs.build/en/933/