Fix RefreshTokenAuthorizer to update refresh_token #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves globus#295 This fix makes the RefreshTokenAuthorizer update its internal `refresh_token` field when one is present in the token_data it receives back. Update the tests for RefreshTokenAuthorizer to be parameterized and have both responses with and without the `refresh_token` field.
sirosen
force-pushed
the
fix-refresh-token-renewal
branch
from
1239533 to
4c4c1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #295
This fix makes the RefreshTokenAuthorizer update its internal
refresh_tokenfield when one is present in the token_data it receives back.Update the tests for RefreshTokenAuthorizer to be parameterized and have both responses with and without the
refresh_tokenfield.