Remove 'tests' package from find_packages() #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't excluding `tests`, which means that installing `globus-sdk` from pypi will also provide a mysterious `tests` package. This can be especially confusing when working with a dependent codebase that has its own top-level `tests` package, as the site-packages dir comes earlier in the pythonpath than `.`, so `import tests` will grab the *sdk* tests package and presumably fail to import properly.
sirosen
added a commit
to sirosen/globus-cli
that referenced
this pull request
Oct 30, 2017
sirosen
added a commit
to sirosen/globus-sdk-python
that referenced
this pull request
Oct 30, 2017
Closed issues since 1.2.1: - globus#232 - globus#233 - globus#231 - globus#229 Three of these are documentation updates, and one is the fix for installing a `tests` package.
sirosen
added a commit
to sirosen/globus-sdk-python
that referenced
this pull request
Nov 1, 2017
Closed issues since 1.2.1: - globus#232 - globus#233 - globus#231 - globus#229 Three of these are documentation updates, and one is the fix for installing a `tests` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't excluding
tests, which means that installingglobus-sdkfrom pypi will also provide a mysterioustestspackage. This can be especially confusing when working with a dependent codebase that has its own top-leveltestspackage, as the site-packages dir comes earlier in the pythonpath than., soimport testswill grab the sdk tests package and presumably fail to import properly.Since this can break client applications' testsuites, I kind of think it's a "big deal" once you notice it, though most people probably won't ever notice.
I noticed while refactoring another application to move its tests from
package_name.teststotestsand my whole testsuite failed strangely.