Support iterable requested_scopes everywhere #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can pass an iterable like a list of strings and we'll join with spaces. Applies to both forms of 3-legged oauth flow, and to client credentials grants. Includes several tests to ensure that it's all working. Missing doc updates. Resolves globus#184
Native App and base 3-legged OAuth flow params are now directly documented on the oauth2_start_flow() methods, and that documentation is somewhat improved. Example linkage into the examples section, and external documentation linkage has been added there as well. This results in duplicated docs -- for both the oauth2_start_flow() helpers, and the underlying class initializers. If that's the cost of having better docs, so be it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can pass an iterable like a list of strings and we'll join with spaces. Applies to both forms of 3-legged oauth flow, and to client credentials grants.
Includes several tests to ensure that it's all working, and a round of documentation updates to make sure people know it's there.
Closes #184