Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jwk_data get respect ssl_verify=no #161

Merged

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Mar 22, 2017

Take the value off of the given AuthClient object.
Closes #160

It turns out this was the only call where verify wasn't set.

I think I might be the only person who cares about this?

@sirosen sirosen added the bug Something isn't working correctly label Mar 22, 2017
@jaswilli
Copy link
Contributor

I think I might be the only person who cares about this?

I'm curious where you're actually running into an error. All our Auth environments should pass verification, no?

This also seems to have a legitimate test failure.

@sirosen
Copy link
Member Author

sirosen commented Mar 23, 2017

I'll take a look at the test failure tomorrow.

I see this on Python2, as an SNI issue. I can either turn off verification or fix the actual problem. While working up the fix, I tried turning off verification. I'm still working on getting my SNI change in place, but figured that this would be good to take care of as well.

Take the value off of the given AuthClient object.
Closes globus#160
@sirosen sirosen force-pushed the bugfix/ssl-no-verify/decode-id-token branch from 0ceb8ff to 22b2347 Compare March 23, 2017 18:23
@sirosen
Copy link
Member Author

sirosen commented Mar 23, 2017

The AppVeyor build passed because it doesn't run the python-jose dependent tests.

Amended my commit to include a very minor tweak to add the _verify property to the mocked AuthClient used in those tests. The inscrutable failure messages came of that value being a mock.Mock instead of a bool or string.

@sirosen
Copy link
Member Author

sirosen commented Mar 30, 2017

@jaswilli, can I ask that we push this through?

I can't get this internal issue fixed -- I'm having trouble even figuring out what's wrong -- so this is actually blocking me from assembling some working components.

@jaswilli jaswilli merged commit e7e0298 into globus:master Mar 30, 2017
@sirosen sirosen deleted the bugfix/ssl-no-verify/decode-id-token branch April 13, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants