Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Native App PKCE support #154

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Improve Native App PKCE support #154

merged 1 commit into from
Mar 10, 2017

Conversation

jaswilli
Copy link
Contributor

@jaswilli jaswilli commented Mar 8, 2017

  • Generate code_verifier and code_challenge strings that are RFC 7636 compliant:
    • 43-128 characters in length.
    • Contain only the following characters: a-z, A-Z, -, _, ., ~.

Needs to wait until Auth handles code verifiers without the padding.

@jaswilli jaswilli added the blocked There's some reason we can't do this label Mar 8, 2017
@jaswilli jaswilli removed the blocked There's some reason we can't do this label Mar 8, 2017
@jaswilli jaswilli changed the title [HOLD] Improve Native App PKCE support Improve Native App PKCE support Mar 10, 2017
@jaswilli
Copy link
Contributor Author

The Globus Auth changes have been released to production so this can be merged/released.

@sirosen sirosen merged commit a02a301 into globus:master Mar 10, 2017
@jaswilli jaswilli deleted the fixup-pkce branch March 11, 2017 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaswilli @sirosen