Add a TimersClient app scope helper for data_access + example doc #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
MaxTueckeGlobus
as code owners
This is a Timers helper for setting up a data_access scope in the correct nested context. It has identical validation to the Transfer equivalent, and is tested for parity.
This is a new (experimental) example, meant to replace the "timer_operations" examples with a more refined usage, based on GlobusApp. It relies on `TimersClient.add_app_transfer_data_access_scope`.
sirosen
force-pushed
the
timers-client-scope-helper
branch
from
c1d06bf to
ae6a24f
Compare
This moves the doc into non-experimental examples, and replaces the older 'timer_operations' example it was written to replace.
|
After rebasing and asking for a fresh review, I noticed that the doc is in the wrong place because this PR was filed several weeks ago (before GlobusApp moved out of |
ada-globus
reviewed
Oct 22, 2024
docs/experimental/examples/transferring_data/timer_management/create_timer.py
Outdated
Show resolved
Hide resolved
docs/experimental/examples/transferring_data/timer_management/index.rst
Outdated
Show resolved
Hide resolved
ada-globus
reviewed
Oct 22, 2024
Co-authored-by: Ada <107940310+ada-globus@users.noreply.github.com>
sirosen
force-pushed
the
timers-client-scope-helper
branch
from
65ace65 to
7b1321f
Compare
|
I applied the suggestion + amended to add other suggested fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://globus-sdk-python--1074.org.readthedocs.build/en/1074/