-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal ComputeClient #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to Flows, Compute requires a custom `ComputeScopesBuilder` class because its resource server is a service name and its scopes are built around the client ID.
The initial `ComputeClient` only supports a `.get_function()` method to get information about registered functions from the Compute API. Additional methods will be added in subsequent commits.
rjmello
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
MaxTueckeGlobus and
sirosen
as code owners
October 3, 2024 14:57
derek-globus
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly 👍
changelog.d/20241002_125030_30907815+rjmello_compute_client.rst
Outdated
Show resolved
Hide resolved
rjmello
force-pushed
the
compute-client
branch
from
October 3, 2024 16:29
b1d69ba
to
8b4152d
Compare
kurtmckee
approved these changes
Oct 3, 2024
derek-globus
approved these changes
Oct 3, 2024
sirosen
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that you were able to figure everything out, including our somewhat arcane sphinx customizations!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of limiting the scope of this PR, I've created a minimal
ComputeClient
class with a single.get_function(...)
method to get information about registered functions from the Compute API. Additional methods will be added in subsequent PRs.Similar to Flows, Compute requires a custom
ComputeScopesBuilder
class because its resource server is a service name and its scopes are built around the client ID.📚 Documentation preview 📚: https://globus-sdk-python--1071.org.readthedocs.build/en/1071/