Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flows all scope #1016

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

derek-globus
Copy link
Contributor

@derek-globus derek-globus commented Jul 26, 2024

What?

  • Added the flows:all to the FlowsScopes object.

Testing

Used the following script to print my flows in sandbox using flows:all

from globus_sdk import Scope, FlowsClient
from globus_sdk.experimental.globus_app import GlobusAppConfig, UserApp

SANDBOX_NATIVE_CLIENT = 'bdf9595f-2d0d-412b-a721-2767d7959404'
app = UserApp("test-flows-all", client_id=SANDBOX_NATIVE_CLIENT, config=GlobusAppConfig(environment="sandbox"))

flows = FlowsClient(app=app, app_scopes=[Scope(FlowsClient.scopes.all)])
flow = flows.list_flows()["flows"][0]

print("First Flow")
print(flow)

Output

Please authenticate with Globus here:
-------------------------------------
https://auth.sandbox.globuscs.info/v2/oauth2/authorize?client_id=bdf9595f-2d0d-412b-...trunc...
-------------------------------------
Enter the resulting Authorization Code here: ...trunc...

First Flow
{'id': '3792a8ac-a48f-42e7-9725-32c67a7b9a63', ...trunc...}

📚 Documentation preview 📚: https://globus-sdk-python--1016.org.readthedocs.build/en/1016/

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I wanted to hold this change back because I thought we should wait until after the release which adds support, but since the scope exists, it's at least non-harmful to release in the SDK. And probably these will release near the same time.

@derek-globus
Copy link
Contributor Author

I had a similar thought; worst case scenario (realistically) is that this gets pushed out a day or two before service support if we have an urgent SDK patch to make.

More likely scenario is that I can cut a release of the SDK next wednesday along with the flows release.

@derek-globus derek-globus merged commit a5f8045 into globus:main Jul 26, 2024
16 checks passed
@derek-globus derek-globus deleted the flows-all-scope branch July 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants