Skip to content

Commit

Permalink
Bug fixes for search functionality
Browse files Browse the repository at this point in the history
A bug in CRUD for both Search Subjects and Entries caused parameters
to be lost before the request was sent, resulting in errors from
Globus Search.
  • Loading branch information
NickolausDS committed Jan 23, 2018
1 parent 1672d3c commit 959ec76
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions globus_sdk/search/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def get_subject(self, index_id, subject, **params):
in the API documentation for details.
"""
index_id = safe_stringify(index_id)
params = merge_params(params, subject=subject)
merge_params(params, subject=subject)

self.logger.info("SearchClient.get_subject({}, {}, ...)"
.format(index_id, subject))
Expand All @@ -294,7 +294,7 @@ def delete_subject(self, index_id, subject, **params):
in the API documentation for details.
"""
index_id = safe_stringify(index_id)
params = merge_params(params, subject=subject)
merge_params(params, subject=subject)

self.logger.info("SearchClient.delete_subject({}, {}, ...)"
.format(index_id, subject))
Expand Down Expand Up @@ -332,7 +332,7 @@ def get_entry(self, index_id, subject, entry_id=None, **params):
in the API documentation for details.
"""
index_id = safe_stringify(index_id)
params = merge_params(params, subject=subject, entry_id=entry_id)
merge_params(params, subject=subject, entry_id=entry_id)

self.logger.info("SearchClient.get_entry({}, {}, {}, ...)"
.format(index_id, subject, entry_id))
Expand Down Expand Up @@ -439,7 +439,7 @@ def delete_entry(self, index_id, subject, entry_id=None, **params):
in the API documentation for details.
"""
index_id = safe_stringify(index_id)
params = merge_params(params, subject=subject, entry_id=entry_id)
merge_params(params, subject=subject, entry_id=entry_id)
self.logger.info("SearchClient.delete_entry({}, {}, {}, ...)"
.format(index_id, subject, entry_id))
path = self.qjoin_path("v1/index", index_id, "entry")
Expand Down

0 comments on commit 959ec76

Please sign in to comment.